Tiny fixes found while preparing next session of the advanced course #493
+12
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponce
force-pushed
the
sponce_fixes_autumn_24
branch
from
ab8b966 to
8d2bcdf
Compare
bernhardmgruber
approved these changes
Oct 11, 2023
talk/basicconcepts/assert.tex
Outdated
| std::is_floating_point<UserType>::value, | ||
| std::is_floating_point_v<UserType>, |
There was a problem hiding this comment.
Requires C++17 now, but the slide says 11. I guess this was the reason, the former version was used. But I totally agree that we should teach the students to use the _v traits!
There was a problem hiding this comment.
Well spotted ! I added a comment "C++17" on the given line, leaving 11 at the top as it targets the static_assert there.
sponce
force-pushed
the
sponce_fixes_autumn_24
branch
from
8d2bcdf to
102cc15
Compare
bernhardmgruber
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.